Switch from AppVeyor to GitHub Actions.#2072
Conversation
ba28549 to
10a9623
Compare
10a9623 to
c30aec3
Compare
daviesrob
left a comment
There was a problem hiding this comment.
Again, it would be useful to leave Appveyor in place for a few days while we swap over.
| ./configure | ||
| make -j32 |
There was a problem hiding this comment.
Configure should use --enable-werror so warnings will be obvious.
make -j32 seems a bit ambitious given that the runners only have 4 CPUs.
| ./configure | ||
| make -j32 |
There was a problem hiding this comment.
Seem comments on the "Compile htslib" section.
There was a problem hiding this comment.
I switched to make -j6. I know it has 4 CPUs, but often with mingw it becomes I/O bound so over-committing on CPUs can speed things up.
There was a problem hiding this comment.
I'll try a -j4 and look at timings too :)
3a131cf to
07189fb
Compare
07189fb to
fd6070c
Compare
|
Comparing with the old AppVeyor logs, I noticed that One remaining issue is that HTSlib's |
Also changed test/** to text mode as Actions enforces windows cr-lf on git clone, unlike AppVeyor's git. Added back a few obvious files as text so any PRs made will revert local cr-lf back on commit. We could be more explicit, but I think this covers most likely candidates. [If we wish to cross-validate our support for e.g. SAM in both line endings, then this should be done by explicit files with both types so we can validate on both platforms, but I don't know if we wish to support that anyway.] At the time of writing (NB it's late afternoon UK time so during peak US time for github), GitHub Actions completed in ~6 mins while AppVeyor took approx 12+ minutes (only 10 of which was running with 2-3 spent waiting for a runner to be available). Co-authored-by: Rob Davies <rmd+git@sanger.ac.uk>
77c8c43 to
f1c88de
Compare
|
Pushed version with tweaked MSYS2 package lists, and added libdeflate. Comparing logs with AppVeyor show the same results, apart from the usage tests which are skipped due to |
Also changed test/** to text mode as Actions enforces windows cr-lf on git clone, unlike AppVeyor's git. We could be more selective in this, but this replicates what we had before.
[If we wish to cross-validate our support for e.g. SAM in both line endings, then this should be done by explicit files with both types so we can validate on both platforms, but I don't know if we wish to support that anyway.]
At the time of writing (NB it's late afternoon UK time so during peak US time for github), GitHub Actions completed in ~6 mins while AppVeyor took approx 12+ minutes (only 10 of which was running with 2-3 spent waiting for a runner to be available).