Don't look at chr "*" for unmapped-placed reads with view --fetch-pairs#2070
Merged
Conversation
The logic previously included `rec->core.flag & BAM_FMUNMAP` but a placed read while unmapped does have a chromesome and position. Searching in HTS_IDX_NOCOOR is both a very expensive operation and also won't actually find the pair we're looking for. Also fixed the test data. It looks like one record was manually edited to move it to the unmapped chr "*", but none of the other fields were corrected. Hence it breaks the assertion in the man page about RNEXT, PNEXT and TLEN being correct. Fixes samtools#2059
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic previously included
rec->core.flag & BAM_FMUNMAPbut a placed read while unmapped does have a chromesome and position. Searching inHTS_IDX_NOCOORis both a very expensive operation and also won't actually find the pair we're looking for.Also fixed the test data. It looks like one record was manually edited to move it to the unmapped chr "*", but none of the other fields were corrected. Hence it breaks the assertion in the man page about RNEXT, PNEXT and TLEN being correct.
Fixes #2059