Fix bed_index regression#1975
Merged
Merged
Conversation
The two inversions cancelled out, with the result that only the first chromosome in the hash table got sorted and indexed. This caused unordered BED files to stop working, and also made lookups on most chromosomes less efficient.
Member
Author
|
NEWS item added... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The checks for failure of
bed_index()andbed_index_core()were all inverted, causingbed_index()to stop after only processing entries for one reference. This resulted inbed_filter()becoming less efficient on all but the one reference that was indexed; and searches to fail on unsorted BED files.Fixed by writing the failure tests correctly, and adding a test on unsorted BED inputs.
Fixes #1974