Add missing samtools merge return code check#1394
Merged
daviesrob merged 2 commits intosamtools:developfrom Mar 15, 2021
Merged
Add missing samtools merge return code check#1394daviesrob merged 2 commits intosamtools:developfrom
daviesrob merged 2 commits intosamtools:developfrom
Conversation
(If this is NULL, calling finish_rg_pg() on it will crash.)
Member
|
Thanks. I've taken the liberty of adding a NEWS item. |
Member
Author
|
This prevents the observed segfault, but there still appear to be failure routes through |
Member
|
Ok, I will remove the "fixed ..." bit. |
Member
Author
|
Cheers. Probably ought to credit Kemin Zhou for discovering the problem too. |
Member
|
Adjusted. Apologies for the force push. |
Member
Author
|
No apology needed 😄 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents a segfault in cases like #1393, though I don't know how the headers in that issue's input files have managed to get
NULLfromtrans_rg_pg().