Skip to content

[cat] Fix the short option for the number of threads#1337

Merged
daviesrob merged 1 commit intosamtools:developfrom
valeriuo:cat_threads_fix
Nov 12, 2020
Merged

[cat] Fix the short option for the number of threads#1337
daviesrob merged 1 commit intosamtools:developfrom
valeriuo:cat_threads_fix

Conversation

@valeriuo
Copy link
Copy Markdown
Contributor

@valeriuo valeriuo commented Nov 9, 2020

samtools cat was missing the short option for the number of threads from the option string passed to getopt_long. This caused optarg to be 0.

Fixes #1336

@jmarshall
Copy link
Copy Markdown
Member

jmarshall commented Nov 9, 2020

Try samtools cat -x (or any other unused option letter), which also crashes.

Also needs an explicit case '?' with a fall-through from default as done in e.g. cut_target.c.

@jmarshall
Copy link
Copy Markdown
Member

jmarshall commented Nov 9, 2020

👍

@daviesrob daviesrob merged commit 1e32ab3 into samtools:develop Nov 12, 2020
@valeriuo valeriuo deleted the cat_threads_fix branch November 13, 2020 14:15
@pickettbd pickettbd mentioned this pull request Dec 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Samtools cat option for threads (-@) is invalid

3 participants

@valeriuo @jmarshall @daviesrob