update for filters which refer header data#1959
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filter expressions which needs header information, like rname, mrname, rnext and library, will not work well when used along with iterators. Filter processing uses fp->bam_header but it will be empty except for sam files and causes this.
This PR sets htsFile's bam_header with header that is read on sam_hdr_read api. This ensures that the bam_header field is not empty and available for filter evaluation.
To keep the bam_header in sync with data, the same is released and reset on header write.
Added get/set methods that header can be set and retrieved from file pointer.