Merged
Conversation
So distclean-all, check-all and test-all targets can be added to samtools/bcftools build systems.
The original message printed when the submodule files are not present could be confusing if HTSlib was being built as an embedded part of SAMtools. Alter the message slightly to make it clearer that the submodule needs to be updated in the htslib checkout. Fixes samtools/samtools#1364
jkbonfield
reviewed
Feb 15, 2021
| # clean: clean-htslib | ||
|
|
||
| all-htslib clean-htslib install-htslib plugins-htslib: | ||
| all-htslib check-htslib clean-htslib distclean-htslib install-htslib plugins-htslib test-htslib: |
Contributor
There was a problem hiding this comment.
Should we also have check-all test-all and distclean-all targets, in a similar vein to clean-all?
"distclean-all" is the one I miss the most when testing releases.
Member
Author
There was a problem hiding this comment.
Those would need to be added to the samtools and bcftools Makefiles. The parts here are the bits that they reference and need to be in place first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small updates for build / release:
.gitattributesto keep.cirrus.ymlout of release tar fileshtslib.mkso HTSlib'sdistcleanandcheck / testcan be run from packages that embed it (e.g. SAMtools / BCFtools).