fix a serious bug when get next overlapped matched base in the case t…#1196
Closed
wulj2 wants to merge 2 commits intosamtools:developfrom
Closed
fix a serious bug when get next overlapped matched base in the case t…#1196wulj2 wants to merge 2 commits intosamtools:developfrom
wulj2 wants to merge 2 commits intosamtools:developfrom
Conversation
added 2 commits
December 24, 2020 00:56
…he match base is in just the first one in the stretch of match and this stretch of match is after some other stretch of non-match sequences(such as ins, del, .etc)
Contributor
|
Thank your for the fix. However, I've made one which is simpler. Instead of keeping track of a previous matching segment, it resets |
Author
|
wow, that is a really clever fix, I love it so much.
…On Thu, Jan 14, 2021 at 12:37 AM Valeriu Ohan ***@***.***> wrote:
Thank your for the fix. However, I've made one
<valeriuo@2d03483>
which is simpler. Instead of keeping track of a previous matching segment,
it resets icig to -1 every time, so that the first base of each matching
segment starts from 0.
I rebased and squashed your commits and added my changes on top of yours,
to preserve your authorship.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1196 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJBMPDAM7234H73R2B6DHODSZXD23ANCNFSM4VHHORTA>
.
|
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…he match base is in just the first one in the stretch of match and this stretch of match is after some other stretch of non-match sequences(such as ins, del, .etc)
fixed#1195