Fix assumption of pthread_t being a non-structure.#1167
Merged
daviesrob merged 1 commit intosamtools:developfrom Nov 6, 2020
Merged
Fix assumption of pthread_t being a non-structure.#1167daviesrob merged 1 commit intosamtools:developfrom
daviesrob merged 1 commit intosamtools:developfrom
Conversation
Replaces samtools#1154 See also samtools#1153 It does this by the addition of a separate variable to do the boolean check on instead of fd->dispatcher itself. I deemed this easier to understand than overloading the interpretation of fd->h being set plus I'm unsure of the potential failure case in sam_hdr_fill_hrecs where fd->h has been set but we errored before creating the threads. Also improves error recovering in case of pthread creation failure, avoiding a false pthread_join later. Thanks to John Marshall and Anders Kaplan for identifying that issue.
ef47d11 to
0ad12d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #1154
See also #1153
It does this by the addition of a separate variable to do the boolean check on instead of fd->dispatcher itself. I deemed this easier to understand than overloading the interpretation of fd->h being set plus I'm unsure of the potential failure case in sam_hdr_fill_hrecs where fd->h has been set but we errored before creating the threads.
Also improves error recovering in case of pthread creation failure, avoiding a false pthread_join later. Thanks to John Marshall for identifying that issue.