Include <unistd.h> and <errno.h> directly where needed#1145
Merged
daviesrob merged 1 commit intosamtools:developfrom Oct 5, 2020
Merged
Include <unistd.h> and <errno.h> directly where needed#1145daviesrob merged 1 commit intosamtools:developfrom
daviesrob merged 1 commit intosamtools:developfrom
Conversation
Similarly to the previous commit, sam.c needs <unistd.h> explicitly for environments in which it doesn't get it via <zlib.h> or similar. Both htslib/sam.h and test/test-vcf-api.c use errno but get it only semi-accidentally via htslib/kstring.h. Include <errno.h> explicitly, and similarly <string.h> for strerror(). Various test/*.c programs that use getopt() need include only <unistd.h> rather than <getopt.h>, which is needed only for getopt_long().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similarly to PR #1143, sam.c also needs
<unistd.h>explicitly for environments in which it doesn't get it via<zlib.h>or similar.Both htslib/sam.h and test/test-vcf-api.c use
errnobut get it only semi-accidentally via htslib/kstring.h. Include<errno.h>explicitly, and similarly<string.h>forstrerror().Various test/*.c programs that use
getopt()need include only<unistd.h>rather than<getopt.h>, which is needed only forgetopt_long().All uncovered by building in an environment with dummy
<zlib.h>and<getopt.h>headers that don't#includeany other headers or define anything extraneous, and temporarily commenting out#include <errno.h>and othererrnousage in htslib/*.h.