.vcf.bgz as a valid vcf extension in FileExtensions#1727
Merged
lbergelson merged 2 commits intosamtools:masterfrom Oct 29, 2024
Merged
.vcf.bgz as a valid vcf extension in FileExtensions#1727lbergelson merged 2 commits intosamtools:masterfrom
lbergelson merged 2 commits intosamtools:masterfrom
Conversation
lbergelson
approved these changes
Oct 29, 2024
Member
lbergelson
left a comment
There was a problem hiding this comment.
👍 Looks like an improvement to me. My only comment is that we might want to make it a method "hasCompressedVcfExtension()" or something like that. We can always revisit that in the future though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
VCF suppliers like gnomad, provide VCF with the vcf.bgz extension (eg https://storage.googleapis.com/gcp-public-data--gnomad/release/4.1/vcf/exomes/gnomad.exomes.v4.1.sites.chr1.vcf.bgz ) . This PR adds vcf.bgz as a valid extension, defined as COMPRESSED_VCF_BGZ
Things to think about before submitting: