improve gff: add Locatable to Gff3BaseData, add 'Optional<String> getAttr(key)' and 'hasAttribute'#1726
Merged
lbergelson merged 3 commits intosamtools:masterfrom Oct 29, 2024
Merged
Conversation
lbergelson
requested changes
Oct 29, 2024
Member
lbergelson
left a comment
There was a problem hiding this comment.
@lindenb This seems like a good idea but can we change the method name? getAttr and getAttribute are to confusing together. Something like getSingleAttribute() might be clearer?
| * @return <tt>Optional<String></tt> if this map contains zero or one attribute for the specified key | ||
| * @throws IllegalArgumentException if there is more than one value | ||
| */ | ||
| public Optional<String> getAttr(final String key) { |
Member
There was a problem hiding this comment.
I like this idea. Can we change the name though? Maybe getSingleAttribute()?
Member
|
or getUniqueAttribute() |
Contributor
Author
|
@lbergelson thanks for the review ! I changed the name to |
Member
|
Thanks for all these additions @lindenb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the GFF3 classes:
List<String> getAttribute(key)can be cumbersome. This PR adds a new functionOptional<String> getAttr(key), it returns an Optional if there is zero or one value. Otherwise an exception is thrown.hasAttributeto test for the presence of an attribute.implements Locatableto Gff3BaseDataThings to think about before submitting: