Skip to content

add ReferenceSequenceFile.getSubsequenceAt(final Locatable locatable ) shortcut to getSubsequenceAt(loc.getContig(), loc.getStart(), loc.getEnd())#1725

Merged
lbergelson merged 1 commit intosamtools:masterfrom
lindenb:pl_reference_locatable
Oct 28, 2024

Conversation

@lindenb
Copy link
Contributor

@lindenb lindenb commented Oct 28, 2024

Description

A small PR that adds a default method to ReferenceSequenceFile.java

getSubsequenceAt(final Locatable loc )

shortcut to

getSubsequenceAt(loc.getContig(), loc.getStart(), loc.getEnd())

Things to think about before submitting:

  • Make sure your changes compile and new tests pass locally
  • Add new tests or update existing ones:
  • Extended the README / documentation, if necessary
  • Check your code style.
  • Write a clear commit title and message

@lindenb lindenb marked this pull request as ready for review October 28, 2024 13:54
Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lindenb Seems like a good idea to me! Thank you.

@lbergelson lbergelson merged commit fd56496 into samtools:master Oct 28, 2024
@lindenb lindenb deleted the pl_reference_locatable branch October 28, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants