Replace toPath().toString() with getURIString()#1719
Merged
Conversation
* Replace toPath().toString() with toUriString() this should prevent the scheme from being cutoff unintentionally
cmnbroad
approved these changes
Oct 7, 2024
Collaborator
cmnbroad
left a comment
There was a problem hiding this comment.
Looks good - thx for catching this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@cmnbroad This is a fix for an issue that @kshakir discovered. It dropping the scheme because it's using toPath().toString() instead of either toPath().toUri().toString() or getURIString().
I added a JIMFS test which fails without the changes. In a second commit I refactored the code with the optionals a bit. I think it's clearer.