Fix IOUtil.unrollPaths for http paths with query parameters#1688
Merged
lbergelson merged 2 commits intomasterfrom Oct 13, 2023
Merged
Fix IOUtil.unrollPaths for http paths with query parameters#1688lbergelson merged 2 commits intomasterfrom
lbergelson merged 2 commits intomasterfrom
Conversation
* Query parameters in an http path were breaking extension detection
jamesemery
approved these changes
Oct 13, 2023
jamesemery
left a comment
There was a problem hiding this comment.
Just tested this with my SAS token issue in GATK. 👍
| @@ -0,0 +1,3 @@ | |||
| src/test/resources/htsjdk/samtools/io/Level1.fofn | |||
| http://www.example.com/blurg.vcf | |||
| http://www.example.com/blurg.vcf?huh=bleep,bloop | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.