two methods for Genotype: HasRefAllele HasAltAllele#1678
Merged
lbergelson merged 1 commit intosamtools:masterfrom Aug 8, 2023
Merged
two methods for Genotype: HasRefAllele HasAltAllele#1678lbergelson merged 1 commit intosamtools:masterfrom
lbergelson merged 1 commit intosamtools:masterfrom
Conversation
lbergelson
approved these changes
Aug 8, 2023
Member
lbergelson
left a comment
There was a problem hiding this comment.
@lindenb This looks good to me. Thank you.
| /** | ||
| * @return true if Allele is either {@code <NON_REF>} or {@code <*>} | ||
| */ | ||
| boolean isNonRefAllele(); |
Member
There was a problem hiding this comment.
Good call. This method is very confusingly named.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I wrote two new functions for
Genotype:hasAltAlleleandtestHasRefAllelebecause I often need to detect whether an ALT allele (or a REF) is present in a Genotype whatever is the genotype ploidyI also copied a javadoc from SimpleAllele to Allele.
Things to think about before submitting: