Avoid disabled typedef in FreeBSD-specific code#119
Merged
Conversation
Setting _XOPEN_SOURCE causes FreeBSD's u_long not to be defined. Write it out as the corresponding native type (fortunately u_long's definition has been unchanged since 1994).
Member
Author
|
That is, when compiled via HTSlib's build infrastructure, rANS_static4x16pr.c gets compiled with |
Member
|
Thanks, the change looks fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 6dadc2a / samtools/htslib#1628, this code is compiled with
_XOPEN_SOURCEset, usually to 600.Setting this causes FreeBSD's
<sys/types.h>not to define these old BSD-style typenames such asu_long. Happily we can just write it out as the corresponding native type — fortunatelyu_long's definition has not changed in 30+ years…