Skip to content

Fix DATABASE_URL support#575

Merged
jcormier merged 2 commits intosameersbn:masterfrom
znz:fix-DATABASE_URL-support
Feb 25, 2025
Merged

Fix DATABASE_URL support#575
jcormier merged 2 commits intosameersbn:masterfrom
znz:fix-DATABASE_URL-support

Conversation

@znz
Copy link
Contributor

@znz znz commented Feb 10, 2025 •
edited
Loading

Because this script updates config/database.yml, it also need to set DB_PASS and DB_NAME.

Without this, config/database.yml includes password: '' and database: redmine_production (that does not match DATABASE_URL), and I see following errors.

[4fe1db4e-b38a-4e67-bfb2-049dbfea712d] ActiveRecord::ConnectionNotEstablished (connection to server at "172.17.0.2", port 5432 failed: fe_sendauth: no password supplied
):
[4fe1db4e-b38a-4e67-bfb2-049dbfea712d] 
Causes:
[4fe1db4e-b38a-4e67-bfb2-049dbfea712d] PG::ConnectionBad (connection to server at "172.17.0.2", port 5432 failed: fe_sendauth: no password supplied
)

@znz
Fix DATABASE_URL support
106a0cd 
Because this script updates `config/database.yml`,
it also need to set `DB_PASS` and `DB_NAME`.
@jcormier
Copy link
Collaborator

jcormier commented Feb 12, 2025

Thanks. Could you provide an example DATABASE_URL in a comment for postgres and mysql2 so it's clear how to test the code?

@jcormier
Copy link
Collaborator

jcormier commented Feb 25, 2025

Thanks

@jcormier jcormier merged commit c04e3c1 into sameersbn:master Feb 25, 2025
1 check passed
@jcormier
Copy link
Collaborator

jcormier commented Feb 25, 2025

Do you want a version number release or are you fine with using latest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@znz @jcormier