Skip to content

Downgrade the goleak version to one that is compatible with the go version #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samber merged 2 commits into from
Jun 22, 2024
Merged

Downgrade the goleak version to one that is compatible with the go version #44

samber merged 2 commits into from
Jun 22, 2024

Conversation

@taman9333
Copy link
Contributor

@taman9333 taman9333 commented Jun 22, 2024

The Golang version, along with some dependencies, has been upgraded here. However, in a later commit, the Golang version was downgraded again to 1.18 without the dependencies.

Currently, the CI will fail when running tests due to this error

# go.uber.org/goleak/internal/stack
../../../.asdf/installs/golang/1.18/packages/pkg/mod/go.uber.org/goleak@v1.3.0/internal/stack/stacks.go:123:26: undefined: errors.Join
../../../.asdf/installs/golang/1.18/packages/pkg/mod/go.uber.org/goleak@v1.3.0/internal/stack/stacks.go:256:26: undefined: strings.CutPrefix
note: module requires Go 1.20

@taman9333
Copy link
Contributor Author

taman9333 commented Jun 22, 2024

@samber

@samber
Copy link
Owner

samber commented Jun 22, 2024

Ok, thanks for your help. I was struggling with that issue earlier today.

@samber samber merged commit 1c2de46 into samber:master Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@taman9333 @samber