Skip to content

fix: reset n counter per iteration in it.Replace#799

Merged
samber merged 1 commit intosamber:masterfrom
LikimiaD:fix/798-it-replace-shared-counter
Feb 21, 2026
Merged

fix: reset n counter per iteration in it.Replace#799
samber merged 1 commit intosamber:masterfrom
LikimiaD:fix/798-it-replace-shared-counter

Conversation

@LikimiaD
Copy link
Contributor

Fixes #798

@LikimiaD LikimiaD force-pushed the fix/798-it-replace-shared-counter branch from 98ca2f0 to ad4cb20 Compare February 15, 2026 19:01
@LikimiaD LikimiaD marked this pull request as ready for review February 15, 2026 19:01
@LikimiaD
Copy link
Contributor Author

Сhecked сhanges - seems that minimal edits were needed to fix the bug

@samber
Copy link
Owner

samber commented Feb 21, 2026

Thanks !

@codecov
Copy link

codecov bot commented Feb 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.32%. Comparing base (d269b33) to head (ad4cb20).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #799      +/-   ##
==========================================
+ Coverage   94.29%   94.32%   +0.03%     
==========================================
  Files          18       18              
  Lines        2857     2857              
==========================================
+ Hits         2694     2695       +1     
+ Misses        149      148       -1     
  Partials       14       14              
Flag Coverage Δ
unittests 94.32% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samber samber merged commit 48d6af1 into samber:master Feb 21, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Question: n counter in it.Replace is shared across iterations

2 participants