Skip to content

Conversation

@mabrarov
Copy link
Contributor

@mabrarov mabrarov commented Oct 2, 2025

Conversion from slice to map with index passed to transformation function (#601).

…n function (samber#601).

Signed-off-by: Marat Abrarov <abrarov@gmail.com>
@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.54%. Comparing base (7feda10) to head (9c28ee4).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #697      +/-   ##
==========================================
+ Coverage   94.51%   94.54%   +0.03%     
==========================================
  Files          18       18              
  Lines        3429     3448      +19     
==========================================
+ Hits         3241     3260      +19     
  Misses        174      174              
  Partials       14       14              
Flag Coverage Δ
unittests 94.54% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samber samber merged commit 71b5295 into samber:master Oct 2, 2025
11 checks passed
@mabrarov mabrarov mentioned this pull request Oct 2, 2025
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @samber,

Considering implementation of similar functions in it/seq.go file of #672 (e.g. it.Filter and it.FilterI), do you find it reasonable to do the same here, i.e. implement Associate with AssociateI, SliceToMap with SliceToMapI and FilterSliceToMap with FilterSliceToMapI?

Thank you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it will be found reasonable, then here is PR: #698

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants