Skip to content

Conversation

@rasha108bik
Copy link
Contributor

@rasha108bik rasha108bik commented Mar 30, 2025

Added FilterKeys transforms a map into a slice based on predicate returns truthy for specific elements.

@rasha108bik rasha108bik changed the title Add **FindKeysBy** for map #614 Add FindKeysBy for map #614 Mar 30, 2025
@rasha108bik rasha108bik changed the title Add FindKeysBy for map #614 Add FindKeysBy for map Apr 13, 2025
@rasha108bik
Copy link
Contributor Author

Solves #614

@samber
Copy link
Owner

samber commented Apr 26, 2025

Hey @rasha108bik

I wonder if we should rename this method to FilterKeys ?

Since FindXXX predicates only return a boolean and the final outputs are not slice, it would make sense.

WDYT ?

@rasha108bik rasha108bik changed the title Add FindKeysBy for map Add FilterKeys for map May 8, 2025
@rasha108bik
Copy link
Contributor Author

rasha108bik commented May 8, 2025

Hey @rasha108bik

I wonder if we should rename this method to FilterKeys ?

Since FindXXX predicates only return a boolean and the final outputs are not slice, it would make sense.

WDYT ?

Hey @samber
Thanks, that's a good idea! I fixed it, look again.


Sorry, but I renamed brunch and now my continuation is in the new PR #631

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants