fix(providers): forward systemPromptFile through ACP and detect hermes runtime

saltbo · saltbo · commit eaff9c99bb05 · 2026-04-18T16:39:29.000-04:00
ACP has no dedicated system-message channel, so our daemon-generated agent
work protocol (claim/review lifecycle, identity, trailer) was never reaching
hermes — it only saw the raw task description. Now we read the systemPromptFile
and send it as a separate text block ahead of the task context in the first
`session/prompt` call.

Also register hermes in the runtime detector so `ak identity` and related
commands work when invoked from inside a hermes agent session, and make
`ak identity` fail fast when no runtime can be detected instead of silently
falling back to a "default" bucket.
diff --git a/packages/cli/src/agent/runtime.ts b/packages/cli/src/agent/runtime.ts
@@ -11,6 +11,7 @@ const RUNTIMES: Record<string, RuntimeSpec> = {
   codex: { envVar: "CODEX_CI", commandPattern: /(^|\/)codex(\s|$)/ },
   gemini: { envVar: "GEMINI_CLI", commandPattern: /(^|\/)gemini(\s|$)/ },
   copilot: { envVar: "COPILOT_CLI", commandPattern: /(^|\/)copilot(\s|$)/ },
+  hermes: { envVar: "HERMES_INTERACTIVE", commandPattern: /(^|\/)hermes(\s|$)/ },
 };
 
 export function detectRuntime(): string | null {
diff --git a/packages/cli/src/index.ts b/packages/cli/src/index.ts
@@ -233,12 +233,15 @@ program
   .description("Show agent identity for the current runtime")
   .action(() => {
     const runtime = detectRuntime();
-    const runtimeKey = runtime ?? "default";
-    const identity = loadIdentity(runtimeKey);
+    if (!runtime) {
+      console.error("No supported agent runtime found. Run this command from inside an agent runtime.");
+      process.exit(1);
+    }
+    const identity = loadIdentity(runtime);
     if (!identity) {
       console.error(
         [
-          `No identity found for runtime "${runtimeKey}".`,
+          `No identity found for runtime "${runtime}".`,
           "",
           "Create one explicitly with:",
           "  ak identity create --username <username> [--name <name>]",
@@ -250,7 +253,7 @@ program
       );
       process.exit(1);
     }
-    console.log(`Runtime:     ${runtimeKey}`);
+    console.log(`Runtime:     ${runtime}`);
     console.log(`Agent ID:    ${identity.agent_id}`);
     console.log(`Name:        ${identity.name}`);
     console.log(`Fingerprint: ${identity.fingerprint}`);
diff --git a/packages/cli/src/providers/acp.ts b/packages/cli/src/providers/acp.ts
@@ -16,6 +16,7 @@
  */
 
 import { type ChildProcess, spawn } from "node:child_process";
+import { readFileSync } from "node:fs";
 import { Readable, Writable } from "node:stream";
 import { ToolName } from "@agent-kanban/shared";
 import {
@@ -77,7 +78,8 @@ async function acpExecute(config: AcpRuntimeConfig, opts: ExecuteOpts): Promise<
   await conn.initialize({ protocolVersion: PROTOCOL_VERSION, clientCapabilities: {} });
 
   const sessionId = await openSession(conn, opts);
-  const promptDone = runPromptLoop(conn, sessionId, opts.taskContext, queue, mapState, runtimeState, logger);
+  const systemPrompt = opts.systemPromptFile ? readFileSync(opts.systemPromptFile, "utf-8") : undefined;
+  const promptDone = runPromptLoop(conn, sessionId, opts.taskContext, systemPrompt, queue, mapState, runtimeState, logger);
 
   proc.once("exit", (code) => {
     if (!runtimeState.aborted && code !== 0 && !queue.done) {
@@ -125,15 +127,25 @@ async function runPromptLoop(
   conn: ClientSideConnection,
   sessionId: string,
   taskContext: string,
+  systemPrompt: string | undefined,
   queue: EventQueue,
   mapState: MapState,
   runtime: RuntimeState,
   logger: ReturnType<typeof createLogger>,
 ): Promise<void> {
+  // ACP has no dedicated system-message channel; combine the daemon's agent
+  // work protocol with the task context so the agent gets claim/review
+  // lifecycle instructions before the task description.
+  const prompt = systemPrompt
+    ? [
+        { type: "text" as const, text: systemPrompt },
+        { type: "text" as const, text: taskContext },
+      ]
+    : [{ type: "text" as const, text: taskContext }];
   try {
     const resp: PromptResponse = await conn.prompt({
       sessionId,
-      prompt: [{ type: "text", text: taskContext }],
+      prompt,
     });
     // If abort() has already taken the wheel, let it drive finalization.
     if (runtime.aborted) return;
