fix(ops): fall back on empty-string env vars in killswitch

saltbo · saltbo · commit da43f6752288 · 2026-04-19T15:43:04.000-04:00
GitHub Actions passes unset repo variables as "" rather than undefined,
so `??` would not fall through to defaults. `Number("")` is 0, which
caused every metric to trip on the first manual run. Switch to `||`
so both undefined and "" drop to the built-in defaults.
diff --git a/scripts/cost-killswitch.mjs b/scripts/cost-killswitch.mjs
@@ -28,11 +28,13 @@ if (!ACCOUNT_ID || !API_TOKEN) {
   process.exit(2);
 }
 
+// GitHub Actions passes undefined repo vars as "", so use || to fall through
+// to defaults on both empty string and undefined.
 const thresholds = {
-  workerRequests: Number(process.env.DAILY_WORKER_REQUESTS ?? 1_000_000),
-  d1RowsRead: Number(process.env.DAILY_D1_ROWS_READ ?? 10_000_000),
-  doRequests: Number(process.env.DAILY_DO_REQUESTS ?? 500_000),
-  doDurationSec: Number(process.env.DAILY_DO_DURATION_SEC ?? 100_000),
+  workerRequests: Number(process.env.DAILY_WORKER_REQUESTS || 1_000_000),
+  d1RowsRead: Number(process.env.DAILY_D1_ROWS_READ || 10_000_000),
+  doRequests: Number(process.env.DAILY_DO_REQUESTS || 500_000),
+  doDurationSec: Number(process.env.DAILY_DO_DURATION_SEC || 100_000),
 };
 
 // UTC day window — CF billing resets at 00:00 UTC
