fix: remove deleted labels from tasks

saltbo · saltbo · commit 2a39054e3dc7 · 2026-05-04T13:45:26.000-04:00
diff --git a/apps/web/server/boardRepo.ts b/apps/web/server/boardRepo.ts
@@ -191,11 +191,21 @@ export async function deleteBoardLabel(db: D1, boardId: string, name: string): P
   if (!board) return null;
   const labels = parseBoard(board).labels;
   if (!labels.some((label) => label.name === name)) throw new HTTPException(404, { message: `Label not found: ${name}` });
-  const inUse = await db
-    .prepare("SELECT 1 FROM tasks WHERE board_id = ? AND EXISTS (SELECT 1 FROM json_each(tasks.labels) WHERE json_each.value = ?) LIMIT 1")
-    .bind(boardId, name)
-    .first();
-  if (inUse) throw new HTTPException(409, { message: `Label is in use: ${name}` });
+
+  const tasks = await db
+    .prepare("SELECT id, labels FROM tasks WHERE board_id = ? AND labels IS NOT NULL")
+    .bind(boardId)
+    .all<{ id: string; labels: string }>();
+  const now = new Date().toISOString();
+  const statements = tasks.results
+    .map((task) => {
+      const current = JSON.parse(task.labels) as string[];
+      return { id: task.id, current, next: current.filter((label) => label !== name) };
+    })
+    .filter((task) => task.current.length !== task.next.length)
+    .map((task) => db.prepare("UPDATE tasks SET labels = ?, updated_at = ? WHERE id = ?").bind(JSON.stringify(task.next), now, task.id));
+  if (statements.length > 0) await db.batch(statements);
+
   return updateBoard(db, boardId, { labels: labels.filter((label) => label.name !== name) });
 }
 
diff --git a/apps/web/src/routes/AccountSettingsPage.tsx b/apps/web/src/routes/AccountSettingsPage.tsx
@@ -59,6 +59,8 @@ function BoardItem({ board }: { board: any }) {
 
   async function handleDeleteLabel(name: string) {
     setLabelError(null);
+    const confirmed = window.confirm(`Delete label "${name}" from this board and remove it from all tasks?`);
+    if (!confirmed) return;
     try {
       await deleteLabel.mutateAsync({ boardId: board.id, name });
     } catch (err) {
diff --git a/tests/task-json-fields.test.ts b/tests/task-json-fields.test.ts
@@ -197,4 +197,20 @@ describe("task JSON field parsing (labels, input)", () => {
     expect(Array.isArray(reviewed!.labels)).toBe(true);
     expect(typeof reviewed!.input).toBe("object");
   });
+
+  it("deleteBoardLabel removes the label from tasks on the same board", async () => {
+    const { createTask, getTask } = await import("../apps/web/server/taskRepo");
+    const { deleteBoardLabel } = await import("../apps/web/server/boardRepo");
+    const task = await createTask(db, ownerId, {
+      title: "Delete label propagation",
+      board_id: boardId,
+      labels: ["bug", "feature"],
+    });
+
+    const board = await deleteBoardLabel(db, boardId, "bug");
+    const updated = await getTask(db, task.id, ownerId);
+
+    expect(board!.labels.map((label) => label.name)).not.toContain("bug");
+    expect(updated!.labels).toEqual(["feature"]);
+  });
 });
