Skip to content

Prototype of centralized cycle state stoarge#1098

Closed
MichaReiser wants to merge 15 commits into
salsa-rs:masterfrom
MichaReiser:micha/cycle-storage
Closed

Prototype of centralized cycle state stoarge#1098
MichaReiser wants to merge 15 commits into
salsa-rs:masterfrom
MichaReiser:micha/cycle-storage

Conversation

@MichaReiser

@MichaReiser MichaReiser commented May 21, 2026

Copy link
Copy Markdown
Contributor

Don't look at this :) I only published it to get some early benchmark numbers to understand whether this is an approach worth perusing.

@netlify

netlify Bot commented May 21, 2026

Copy link
Copy Markdown

👷 Deploy Preview for salsa-rs processing.

Name Link
🔨 Latest commit 683bf32
🔍 Latest deploy log https://app.netlify.com/projects/salsa-rs/deploys/6a0ef4c0f7b8100008b02213

@netlify

netlify Bot commented May 21, 2026

Copy link
Copy Markdown

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit ea62234
🔍 Latest deploy log https://app.netlify.com/projects/salsa-rs/deploys/6a1176ab1d015900082ab44c

@codspeed-hq

codspeed-hq Bot commented May 21, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚡ 3 improved benchmarks
❌ 4 regressed benchmarks
✅ 19 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory converge_diverge_nested 12.7 KB 12.1 KB +4.98%
Memory converge_diverge 9.8 KB 5.3 KB +86.16%
Simulation amortized[InternedInput] 2.1 µs 2 µs +5.5%
Simulation amortized[SupertypeInput] 2.7 µs 2.9 µs -5.49%
Simulation new[Input] 9.7 µs 10.4 µs -6.51%
Simulation converge_diverge 166.4 µs 194.3 µs -14.33%
Simulation converge_diverge_nested 130.5 µs 157.5 µs -17.1%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing MichaReiser:micha/cycle-storage (ea62234) with master (7e77c49)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant