Better Exception-Handling for BasePersistence.replace/insert_bot (#2564) #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updated the docstrings to reflect the changes in behavior with unexpected errors
Tests: added to CustomClass immutable object that would trigger a setattr() exception
Tests: added new uuid_ property to own CustomClass methods
Updated AUTHORS.rst
Revert "Tests: added new uuid_ property to own CustomClass methods"
This reverts commit 9e67463.
This reverts commit 1c25830
f-string will perform the string-ification on their own
Removed another unneeded Exception cast to string
Added test to parse unparsable objects in dict or slots
Applied black and pylint style suggestions
All lint tests passed
Co-authored-by: Harshil 37377066+harshil21@users.noreply.github.com
Co-authored-by: Bibo-Joshi hinrich.mahler@freenet.de
Co-authored-by: Harshil 37377066+harshil21@users.noreply.github.com
Checklist for PRs
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)AUTHORS.rst(optional)If the PR contains API changes (otherwise, you can delete this passage)
New classes:
self._id_attrsand corresponding documentation__init__accepts**_kwargsAdded new shortcuts:
Chat&Userfor all methods that acceptchat/user_idMessagefor all methods that acceptchat_idandmessage_idMessageshortcuts: Addedquoteargument if methods acceptsreply_to_message_idCallbackQueryfor all methods that accept eitherchat_idandmessage_idorinline_message_idIf relevant:
telegram.constantsand shortcuts to them as class variablesREADME.rstandREADME_RAW.rst(including the badge), as well astelegram.constants.BOT_API_VERSIONtg.ext.Botfor new methods that either accept areply_markupin some form or have a return type that is/containstelegram.Message