Skip to content

Conversation

@sakibguy
Copy link
Owner

  • Catch exceptions raised while copying dict/slots in BasePersistence.replace/insert_bot()

Also updated the docstrings to reflect the changes in behavior with unexpected errors

  • Tests: added to CustomClass immutable object that would trigger a setattr() exception

  • Tests: added new uuid_ property to own CustomClass methods

  • Updated AUTHORS.rst

  • Revert "Tests: added new uuid_ property to own CustomClass methods"

This reverts commit 9e67463.

  • Revert "Tests: added to CustomClass immutable object that would trigger a setattr() exception"

This reverts commit 1c25830

  • Removed unneeded Exception cast to string

f-string will perform the string-ification on their own

  • Removed another unneeded Exception cast to string

  • Added test to parse unparsable objects in dict or slots

  • Applied black and pylint style suggestions

All lint tests passed

  • Fix typo

Co-authored-by: Harshil 37377066+harshil21@users.noreply.github.com

Co-authored-by: Bibo-Joshi hinrich.mahler@freenet.de
Co-authored-by: Harshil 37377066+harshil21@users.noreply.github.com

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Added myself alphabetically to AUTHORS.rst (optional)

If the PR contains API changes (otherwise, you can delete this passage)

  • New classes:

    • Added self._id_attrs and corresponding documentation
    • __init__ accepts **_kwargs
  • Added new shortcuts:

    • In Chat & User for all methods that accept chat/user_id
    • In Message for all methods that accept chat_id and message_id
    • For new Message shortcuts: Added quote argument if methods accepts reply_to_message_id
    • In CallbackQuery for all methods that accept either chat_id and message_id or inline_message_id
  • If relevant:

    • Added new constants at telegram.constants and shortcuts to them as class variables
    • Added new handlers for new update types
    • Added new filters for new message (sub)types
    • Added or updated documentation for the changed class(es) and/or method(s)
    • Updated the Bot API version number in all places: README.rst and README_RAW.rst (including the badge), as well as telegram.constants.BOT_API_VERSION
    • Added logic for arbitrary callback data in tg.ext.Bot for new methods that either accept a reply_markup in some form or have a return type that is/contains telegram.Message

* Catch exceptions raised while copying __dict__/__slots__ in BasePersistence.replace/insert_bot()

Also updated the docstrings to reflect the changes in behavior with unexpected errors

* Tests: added to CustomClass immutable object that would trigger a setattr() exception

* Tests: added new uuid_ property to own CustomClass methods

* Updated AUTHORS.rst

* Revert "Tests: added new uuid_ property to own CustomClass methods"

This reverts commit 9e67463.

* Revert "Tests: added to CustomClass immutable object that would trigger a setattr() exception"

This reverts commit 1c25830

* Removed unneeded Exception cast to string

f-string will perform the string-ification on their own

* Removed another unneeded Exception cast to string

* Added test to parse unparsable objects in __dict__ or __slots__

* Applied black and pylint style suggestions

All lint tests passed

* Fix typo

Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>

Co-authored-by: Bibo-Joshi <hinrich.mahler@freenet.de>
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
@sakibguy sakibguy added bug Something isn't working documentation Improvements or additions to documentation labels Jun 21, 2021
@sakibguy sakibguy self-assigned this Jun 21, 2021
@sakibguy sakibguy merged commit b6b09b6 into sakibguy:master Jun 22, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants