Merged
Conversation
c4c6a42 to
8f72c64
Compare
…ible_activity_elevation
8f72c64 to
e18830a
Compare
ZacSweers
reviewed
Aug 4, 2019
Reverse-for loops avoided object allocation while allowing callbacks to remove themselves, but weren't foolproof. CopyOnWriteArrayList returns a new copy of the underlying array on every iteration so it's safer. It's also more efficient than using Kotlin's immutable list because it avoids blanket creating a new list with extra capacity everytime a callback is added or removed.
ba134ea to
6c5c7b7
Compare
This was referenced Aug 7, 2019
27a01f9 to
959a489
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements
InboxRecyclerViewand itsExpandablePageLayoutwill always share the same parent and have the same width & height. v2 removes this restriction. (Fixes Strange animation #10).ExpandablePageLayoutsfrom itsInboxRecyclerView, essentially making it possible to use multiple expandable pages with the same list. (Fixes Add a mechanism to reset the page an RV is bound to #32).Breaking changes
InboxRecyclerView.setExpandablePage()is removed in favor of usingInboxRecyclerView.expandablePagedirectly. Kotlin FTW! If you wish to specify the page's collapse threshold then you can again setExpandablePageLayout.pullToCollapseThresholdDistancedirectly.PageStateChangeCallbacksfunctions were updated to include apage: ExpandablePageLayoutparameter. I'm not too happy with this change so I'll try reverting this.