Detach ItemExpandAnimator and TintPainter when InboxRecyclerView is detached

Saket Narayan · Saket Narayan · commit f3ca4b0f206b · 2018-10-09T20:03:00.000+05:30
diff --git a/inboxrecyclerview/src/main/java/me/saket/inboxrecyclerview/InboxRecyclerView.kt b/inboxrecyclerview/src/main/java/me/saket/inboxrecyclerview/InboxRecyclerView.kt
@@ -79,6 +79,14 @@ class InboxRecyclerView(
     super.onRestoreInstanceState(superState)
   }
 
+  override fun onDetachedFromWindow() {
+    super.onDetachedFromWindow()
+    if (pageSetupDone) {
+      itemExpandAnimator.onDetachRecyclerView(this)
+      tintPainter.onDetachRecyclerView(this)
+    }
+  }
+
   /**
    * Set the [ExpandablePageLayout] to be used with this list.
    * The pull-to-collapse threshold is set to 85% of the standard toolbar height.
diff --git a/inboxrecyclerview/src/main/java/me/saket/inboxrecyclerview/dimming/UncoveredAreaTintPainter.kt b/inboxrecyclerview/src/main/java/me/saket/inboxrecyclerview/dimming/UncoveredAreaTintPainter.kt
@@ -68,6 +68,7 @@ open class UncoveredAreaTintPainter(color: Int, opacity: Float) : TintPainter(),
     recyclerView.page.removeStateChangeCallbacks(this)
     recyclerView.page.viewTreeObserver.removeOnGlobalLayoutListener(pageLayoutChangeListener)
     recyclerView.page.viewTreeObserver.removeOnPreDrawListener(pagePreDrawListener)
+    tintAnimator.cancel()
   }
 
   private fun onPageMove() {

Original file line number	Diff line number	Diff line change
`@@ -68,6 +68,7 @@ open class UncoveredAreaTintPainter(color: Int, opacity: Float) : TintPainter(),`
`68`	`68`	`recyclerView.page.removeStateChangeCallbacks(this)`
`69`	`69`	`recyclerView.page.viewTreeObserver.removeOnGlobalLayoutListener(pageLayoutChangeListener)`
`70`	`70`	`recyclerView.page.viewTreeObserver.removeOnPreDrawListener(pagePreDrawListener)`
	`71`	`+ tintAnimator.cancel()`
`71`	`72`	`}`
`72`	`73`
`73`	`74`	`private fun onPageMove() {`