Fix: list items aren't reset when page is collapsed immediately

saket · saket · commit 5217691fd885 · 2019-07-29T22:22:39.000-04:00
This usually happens when battery saver is on.
diff --git a/inboxrecyclerview/src/main/java/me/saket/inboxrecyclerview/animation/PageLocationChangeDetector.kt b/inboxrecyclerview/src/main/java/me/saket/inboxrecyclerview/animation/PageLocationChangeDetector.kt
@@ -5,8 +5,8 @@ import android.view.ViewTreeObserver
 import me.saket.inboxrecyclerview.page.ExpandablePageLayout
 
 internal class PageLocationChangeDetector(
-    private val page: ExpandablePageLayout,
-    private val changeListener: () -> Unit
+  private val page: ExpandablePageLayout,
+  private val changeListener: () -> Unit
 ) : ViewTreeObserver.OnPreDrawListener, ViewTreeObserver.OnGlobalLayoutListener {
 
   private var lastTranslationY = 0F
@@ -28,7 +28,7 @@ internal class PageLocationChangeDetector(
     val dimensionsChanged = lastClippedDimens != page.clippedDimens
     val stateChanged = lastState != page.currentState
 
-    if (page.isCollapsed.not() && (moved || dimensionsChanged || stateChanged)) {
+    if (moved || dimensionsChanged || stateChanged) {
       changeListener()
     }
 
diff --git a/inboxrecyclerview/src/main/java/me/saket/inboxrecyclerview/page/ExpandablePageLayout.kt b/inboxrecyclerview/src/main/java/me/saket/inboxrecyclerview/page/ExpandablePageLayout.kt
@@ -173,7 +173,7 @@ open class ExpandablePageLayout @JvmOverloads constructor(
   override fun onRelease(collapseEligible: Boolean) {
     dispatchOnPageReleaseCallback(collapseEligible)
 
-    if (!collapseEligible.not()) {
+    if (!collapseEligible.not()) {  // TODO: remove double negation.
       return
     }
 

Original file line number	Diff line number	Diff line change
`@@ -173,7 +173,7 @@ open class ExpandablePageLayout @JvmOverloads constructor(`
`173`	`173`	`override fun onRelease(collapseEligible: Boolean) {`
`174`	`174`	`dispatchOnPageReleaseCallback(collapseEligible)`
`175`	`175`
`176`		`- if (!collapseEligible.not()) {`
	`176`	`+ if (!collapseEligible.not()) { // TODO: remove double negation.`
`177`	`177`	`return`
`178`	`178`	`}`
`179`	`179`