Skip to content

feat: runner args#20

Merged
sagiegurari merged 3 commits intosagiegurari:masterfrom
aria-aghaei:runner_args
Mar 1, 2023
Merged

feat: runner args#20
sagiegurari merged 3 commits intosagiegurari:masterfrom
aria-aghaei:runner_args

Conversation

@aria-aghaei
Copy link
Copy Markdown
Contributor

PR to give user the ability to pass args to the runner through ScriptOptions. Comes with 3 new tests, tested on both windows and WSL using cargo make ci-flow.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Patch coverage: 94.87% and project coverage change: -0.34 ⚠️

Comparison is base (bcb477e) 93.79% compared to head (bc67f67) 93.46%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
- Coverage   93.79%   93.46%   -0.34%     
==========================================
  Files           6        6              
  Lines         419      459      +40     
==========================================
+ Hits          393      429      +36     
- Misses         26       30       +4     
Impacted Files Coverage Δ
src/runner.rs 85.21% <75.00%> (-2.01%) ⬇️
src/runner_test.rs 99.57% <100.00%> (+0.06%) ⬆️
src/types.rs 66.66% <100.00%> (+1.44%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sagiegurari sagiegurari merged commit 8c7e44e into sagiegurari:master Mar 1, 2023
@sagiegurari
Copy link
Copy Markdown
Owner

@aria-aghaei this is great work. thanks a lot. i'll release it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants