Conversation
This is a weird one. I'm not sure I'm doing the right thing, so let's see how things evolve. HTTP/2 introduces some complexity since one HTTP connection is no longer equal to a `struct lws_wsi`. This means a lot of care needs to be taken for destroying things in our context. In addition, some logic (redirects, chunked encoding) needs to be written twice basically. Redirect handling has been moved to JS because it's way easier to handle, as cross-domain redirects seem to not work right out of the box. So, I'm making the call to not support HTTP/2 for now. This is a small runtime and right now its drawbacks outweigh the benefits. I suspect a number of these problems are caused by the fact that we are running libuv as our event loop, as a foreign one at that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a weird one. I'm not sure I'm doing the right thing, so let's
see how things evolve.
HTTP/2 introduces some complexity since one HTTP connection is no longer
equal to a
struct lws_wsi. This means a lot of care needs to be takenfor destroying things in our context.
In addition, some logic (redirects, chunked encoding) needs to be
written twice basically.
Redirect handling has been moved to JS because it's way easier to
handle, as cross-domain redirects seem to not work right out of the box.
So, I'm making the call to not support HTTP/2 for now. This is a small
runtime and right now its drawbacks outweigh the benefits.
I suspect a number of these problems are caused by the fact that we are
running libuv as our event loop, as a foreign one at that.