fix: prevent premature garbage collection of xhr in fetch polyfill#737
Merged
saghul merged 2 commits intosaghul:masterfrom Jan 12, 2026
Merged
fix: prevent premature garbage collection of xhr in fetch polyfill#737saghul merged 2 commits intosaghul:masterfrom
saghul merged 2 commits intosaghul:masterfrom
Conversation
saghul
reviewed
Jan 12, 2026
Owner
saghul
left a comment
There was a problem hiding this comment.
Please commit the result of make js and add the repro test to the tests dir so it's tested going forward.
1966efe to
f1d3915
Compare
The `XMLHttpRequest` that is created as part of the `fetch` call could be prematurely garbage-collected because no strong reference to it exists anymore. When this happens (garbage collections runs while the fetch is in progress), this leads to a promise that will never resolve. To fix this, we add a `Set` that tracks all the active XHR's.
This is a regression test for the fetch bug where the XHR object was prematurely garbage-collected.
f1d3915 to
bd9a69b
Compare
Owner
|
Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
XMLHttpRequestthat is created as part of thefetchcall could be prematurely garbage-collected because no strong reference to it exists anymore.When this happens (garbage collections runs while the fetch is in progress), this leads to a promise that will never resolve.
To fix this, we add a
Setthat tracks all the active XHR's.This closes #736