Merged
Conversation
Contributor
Author
|
Some checks aren't succeeding due to #701 |
Owner
|
Merged the other PR, can you rebase? |
Contributor
Author
|
All other tests are fine now. Not sure what macos is complaining about. Will look into that (maybe next week), though otherwise this is reviewable. |
Contributor
Author
|
@saghul any updates here? |
Owner
|
Sorry, I haven't had much time lately, I'll review this ASAP! |
36e49df to
68c0270
Compare
68c0270 to
28922ab
Compare
Owner
|
Alright, let's do this. Thanks for persevering @lal12 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #447
A C implementation for TextEncoder/TextDecoder, due to the limited access to the QuickJS internals it has some unnecessary overhead (basically encoding/decoding is done twice), but it is still much faster than in JS.