ffi: don't unnecessarily create SharedArrayBuffer instances#649
Merged
ffi: don't unnecessarily create SharedArrayBuffer instances#649
Conversation
What we really want is an ArrayBuffer where memory is not freed when the JS object is collected, since the memory is allocated and freed by libffi. In addition, we can remove that hack with the magic number in the SAB allocator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What we really want is an ArrayBuffer where memory is not freed when the JS object is collected, since the memory is allocated and freed by libffi.
In addition, we can remove that hack with the magic number in the SAB allocator.