Skip to content

add release ci#604

Merged
saghul merged 1 commit intosaghul:masterfrom
ahaoboy:master
Jul 15, 2024
Merged

add release ci#604
saghul merged 1 commit intosaghul:masterfrom
ahaoboy:master

Conversation

@ahaoboy
Copy link
Copy Markdown
Contributor

@ahaoboy ahaoboy commented Jul 15, 2024

Support build on windows-x86, macos-x86, macos-arm64

For Windows platform, all dynamic libraries required by tjs are packaged

Only tested in Windows environment https://github.com/ahaoboy/txiki.js/releases

Copy link
Copy Markdown
Owner

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting the ball rolling! Left some comments.

@ahaoboy ahaoboy force-pushed the master branch 4 times, most recently from 2fa942f to 3bbbff6 Compare July 15, 2024 14:18
@ahaoboy
Copy link
Copy Markdown
Contributor Author

ahaoboy commented Jul 15, 2024

@saghul Can BUILD_MACOS_MULTIARCH compile a program that can run on both arm and x86? Very interesting, thank you, learned a lot
However, the product seems to be a little bigger than that of a single platform.

@saghul
Copy link
Copy Markdown
Owner

saghul commented Jul 15, 2024

@saghul Can BUILD_MACOS_MULTIARCH compile a program that can run on both arm and x86? Very interesting, thank you, learned a lot However, the product seems to be a little bigger than that of a single platform.

Yes, that's right! It's larger because it includes both architectures in a single file.

@ahaoboy
Copy link
Copy Markdown
Contributor Author

ahaoboy commented Jul 15, 2024

Yes, that's right! It's larger because it includes both architectures in a single file.

Although I prefer to be platform specific, it's a good deal to trade 2m of program size for the convenience of being able to run on a different architecture.

@saghul
Copy link
Copy Markdown
Owner

saghul commented Jul 15, 2024

Yes, that's right! It's larger because it includes both architectures in a single file.

Although I prefer to be platform specific, it's a good deal to trade 2m of program size for the convenience of being able to run on a different architecture.

Yeah, i think this is ok for macOS, since the only devices that run macOS should have plenty of space so wasting a couple extra megabytes should be ok.

The Makefile still defaults to single-arch builds, so users are free to do that too!

@saghul saghul merged commit 8f7e3e6 into saghul:master Jul 15, 2024
@saghul
Copy link
Copy Markdown
Owner

saghul commented Jul 15, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants