Skip to content

core: introduce tjs.engine#592

Merged
saghul merged 6 commits intomasterfrom
engine
Jul 8, 2024
Merged

core: introduce tjs.engine#592
saghul merged 6 commits intomasterfrom
engine

Conversation

@saghul
Copy link
Copy Markdown
Owner

@saghul saghul commented Jul 8, 2024 •
edited
Loading

It includes the bytecode manipulation functions in addition to the versions object.

This will be the namespace to add engine specific stuff, like the engine memory usage, for example.

TODO: docs.

@saghul saghul force-pushed the engine branch 2 times, most recently from 6b1f3cc to ebb7629 Compare July 8, 2024 08:56
saghul added 4 commits July 8, 2024 14:52
@saghul
core: introduce tjs.engine
52f0506 
It includes the bytecode manipulation functions in addition to the
versions object.

This will be the namespace to add engine specific stuff, like the engine
memory usage, for example.
@saghul
doc: fix exePath definition
afee14a
@saghul
doc: drop no longer existing functions
daffe81
@saghul
doc: fix link
57b8910
@saghul saghul marked this pull request as ready for review July 8, 2024 13:12
@KaruroChori
Copy link
Copy Markdown
Contributor

KaruroChori commented Jul 8, 2024 •
edited
Loading

This regressed/reverted the gc object PR I added few weeks ago features, but tests have not been changed to show that.
Either way it should be fixed.
Sorry just saw it was moved.
The interface in the types file is incomplete for some reason which threw me off. Might it be that I missed to push a commit on that occasion?

@KaruroChori
Copy link
Copy Markdown
Contributor

KaruroChori commented Jul 8, 2024 •
edited
Loading

Also, the documentation generated from ts.d files will only nest children on the left tree view for namespaces, not for interfaces. It might be worth to declare tjs.engine as such, so that its first-level entries will be shown directly on the menu.

@saghul
Copy link
Copy Markdown
Owner Author

saghul commented Jul 8, 2024

The interface in the types file is incomplete for some reason which threw me off. Might it be that I missed to push a commit on that occasion?

Probably yeah!

Also, the documentation generated from ts.d files will only nest children on the left tree view for namespaces, not for interfaces. It might be worth to declare tjs.engine as such, so that its first-level entries will be shown directly on the menu.

Hum, I'll take a look at that, thanks for the heads up!

@saghul
Copy link
Copy Markdown
Owner Author

saghul commented Jul 8, 2024

Screenshot 2024-07-08 at 16 44 46

Looks like it's OK? I see the interfaces as members of the tjs namespace on the left bar.

@KaruroChori KaruroChori mentioned this pull request Jul 8, 2024
Closed
@KaruroChori
Copy link
Copy Markdown
Contributor

KaruroChori commented Jul 8, 2024

Yes, what I was saying is that its children are not shown as a nested menu.
Since tjs.engine is effectively just serving as namespace, it would have made sense to handle it as such from a typing perspective, and so tsdoc would have generated a subfolder in the menu for its children.

@saghul
Copy link
Copy Markdown
Owner Author

saghul commented Jul 8, 2024

Gotcha. Since that was kinda there already, I'll take a look at it all together in a separate PR 👍

@saghul saghul merged commit 4bde355 into master Jul 8, 2024
@saghul saghul deleted the engine branch July 8, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@saghul @KaruroChori