Merged
Conversation
Contributor
lal12
commented
May 27, 2024
- always return a full js instance of posix socket and not internal handle, fixes Poll with SOCK_STREAM sockets #513
- always get info from socket handle
ebe5d50 to
62875fb
Compare
Owner
|
Some test failures, but the approach looks good! |
b1f94d6 to
c0f310f
Compare
- always return a full js instance of posix socket and not internal handle, fixes saghul#513 - always get info from socket handle
Owner
|
Great work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.