Skip to content

misc: remove no longer used JSValueConst type#499

Merged
saghul merged 1 commit intomasterfrom
no-jsvalueconst
Apr 22, 2024
Merged

misc: remove no longer used JSValueConst type#499
saghul merged 1 commit intomasterfrom
no-jsvalueconst

Conversation

@saghul
Copy link
Copy Markdown
Owner

@saghul saghul commented Apr 22, 2024

No description provided.

@saghul saghul merged commit 4866fe9 into master Apr 22, 2024
@saghul saghul deleted the no-jsvalueconst branch April 22, 2024 08:38
@chqrlie
Copy link
Copy Markdown

chqrlie commented Apr 22, 2024

This change is unfortunate, the JSValueConst is used to tell the programmer that the value is not consumed by the function call. The name is not perfect and a more explicit alternative is desirable, but removing the distinction between JSValue and JSValueConst is error-prone, it hides valuable information.

@saghul
Copy link
Copy Markdown
Owner Author

saghul commented Apr 22, 2024

I'll be happy to bring it back if / when we come up with a better replacement! Right now it was just noise and some casting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants