console implementation according to standard#485
Conversation
2174e8a to
2304fba
Compare
|
E.g. would be nice to expose the createConsole function for customization. |
saghul
left a comment
There was a problem hiding this comment.
Great work! Left some comments.
2304fba to
b42b523
Compare
b42b523 to
23add5f
Compare
|
Added tests from wpt and added some changes to fulfill those and match some nodejs behavior. In some places wpt tests seemed to be wrong, and neither browser nor nodejs acted accordingly (but differently from each other), there I used nodejs behavior. JS console standards seems to be oddly wild 😆 Diverging from spec are the following things:
I also copied the code from util package and moved it here to add missing features as defined in console spec. Though alternatively we could extend the alteady existing util patch. |
bfaf6aa to
1311aa4
Compare
Good call, I was thingking about eventually doing that, so thanks for going in that direction. |
|
This looks great! Are you going to be adding anything else, or should we merge? |
Just pushed the types for createConsole. I have nothing else to add. The only thing I was wondering if there is a better way for registering |
It looks odd indeed. I'll take a look. |
|
Excellent work @lal12 ! |
Implementing console according to standard.
Still a bunch of test cases missing, but otherwise complete.
Any thoughts?