Skip to content

fix invalid memory writes#478

Merged
saghul merged 2 commits intosaghul:masterfrom
lal12:fix-ffi-invalid-writes
Apr 9, 2024
Merged

fix invalid memory writes#478
saghul merged 2 commits intosaghul:masterfrom
lal12:fix-ffi-invalid-writes

Conversation

@lal12
Copy link
Copy Markdown
Contributor

@lal12 lal12 commented Apr 9, 2024

Fixes #461

@lal12 lal12 force-pushed the fix-ffi-invalid-writes branch from d72530b to 9ec23bc Compare April 9, 2024 13:41
@lal12
Copy link
Copy Markdown
Contributor Author

lal12 commented Apr 9, 2024

Added some windows build fixes.

@saghul
Copy link
Copy Markdown
Owner

saghul commented Apr 9, 2024

Thank you! Can you please flip the mimalloc build flag to default to on? That's what triggered the failures. This flag:

cpr_option(BUILD_WITH_MIMALLOC "If ON, build with mimalloc" OFF)

@saghul saghul force-pushed the fix-ffi-invalid-writes branch from 118bf00 to d95479f Compare April 9, 2024 20:37
@saghul saghul force-pushed the fix-ffi-invalid-writes branch from d95479f to af1ea20 Compare April 9, 2024 20:38
@saghul saghul merged commit a2d53e7 into saghul:master Apr 9, 2024
@lal12 lal12 deleted the fix-ffi-invalid-writes branch April 15, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid writes on ffi module

2 participants