build: fix libffi building to the wrong directory (https://github.com/saghul/txiki.js/issues/453)#454
Merged
saghul merged 1 commit intosaghul:masterfrom Feb 19, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On systems where
gcc --print-multi-os-directoryoutputs something that is not../lib, Libffi installs to the wrong location (e.g.lib64) where CMake cannot find it and errors, breaking the build. This fix disables placing binaries in other places with the--disable-multi-os-directoryconfiguration flag, forcing Libffi to install tolib.This fix has no effect on systems where Libffi already installs to
lib, and therefore does not break anything.