file: embed polyfill for blob and file#428
Merged
saghul merged 4 commits intosaghul:masterfrom Nov 14, 2023
Merged
Conversation
Owner
|
Thank you! Can you regenerate the C file please? |
Contributor
Author
|
Plz Tell me how. This is my first contribution. |
Owner
|
Ssure, just run |
Contributor
Author
|
Thx, Done! |
Owner
|
Looks like a test is failing, can you check? |
Contributor
Author
|
A blob where constructed with invalid arguments in - new Blob(arrayBuffer)
+ new Blob([ arrayBuffer ]) |
saghul
reviewed
Nov 14, 2023
Owner
|
Thanks a lot! |
Owner
|
I was thinking about using your FormData libary to polyfill FormData, what do you think? |
Contributor
Author
|
Sure. Feel free to copy as much or as little as you want |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a kind of better blob implementation cuz it can references other blobs and dose not have to hold all data in memory.
it's a way better implementation for later being able to create blob's that are backed up by the disk.
it mostly comes from fetch-blob with some minor adjustments