Skip to content

path: update path module to match Node 18#323

Merged
saghul merged 3 commits intomasterfrom
new-path
Nov 8, 2022
Merged

path: update path module to match Node 18#323
saghul merged 3 commits intomasterfrom
new-path

Conversation

@saghul
Copy link
Copy Markdown
Owner

@saghul saghul commented Nov 7, 2022

Including the win32 implementation.

Including the win32 implementation.
Checks correctness on Windows.
In the normalizer, `base_name` is the full path to the module doing the
import, and `name` the import itself.

Thus, we want to normalize the path and make sure Windows paths use the
appropriate separator.

The name, however, is always given with posix style paths.
@saghul saghul merged commit 99baec3 into master Nov 8, 2022
@saghul saghul deleted the new-path branch November 8, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant