Fix module has no attribute type errors#211
Merged
saghul merged 2 commits intosaghul:masterfrom Apr 4, 2025
Merged
Conversation
Owner
|
Sorry I missed this PR. The CI seems unhappy. |
Contributor
Author
|
Wait, _cares isn't a package...? |
Contributor
Author
|
OK, done it the more repetitive way.. |
saghul
approved these changes
Apr 4, 2025
Owner
|
Thank you! Do you have any work pending or shall I cut a new release? |
Contributor
Author
|
That's it. Will work on aiodns as soon as this is up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A type checker like mypy can't tell what attributes exist on the module when they are created dynamically. This results in loads of type errors, such as:
Proposal is to just duplicate everything in the
__any__like nearly all other projects do.