Do not define HAVE_GETSERVBYPORT_R for platforms Android, Cygwin, Darwin#195
Merged
saghul merged 1 commit intosaghul:masterfrom Feb 14, 2024
Merged
Do not define HAVE_GETSERVBYPORT_R for platforms Android, Cygwin, Darwin#195saghul merged 1 commit intosaghul:masterfrom
saghul merged 1 commit intosaghul:masterfrom
Conversation
Owner
|
Can you just delete the lines instead please? |
Contributor
Author
|
I don't see other ares_config.h delete the lines |
Owner
|
So? Delete them please. |
Contributor
Author
|
You mean delete the other ares_config.h lines? |
Owner
|
Instead of putting "undef" and commenting the line out, just delete the line. |
Contributor
Author
|
I follow what other ares_config.h do (undef and comment). So if I do another (delete the line and comments) shouldnt it be applied to others? |
Owner
|
Oh, sorry! I hadn't realized that's how it was done for other options! This is good then, |
saghul
approved these changes
Feb 12, 2024
Android, Cygwin, Darwin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix a long standing issue which Android build keep failing due to undefined getservbyport_r in bionic libc.
I think you can close all Android issues for good like #191 since it obviously a user mistake.