Update test_idna_encoding_query_a with new errno to align to new c-ares version#194
Merged
saghul merged 3 commits intosaghul:masterfrom Jan 2, 2024
Merged
Update test_idna_encoding_query_a with new errno to align to new c-ares version#194saghul merged 3 commits intosaghul:masterfrom
saghul merged 3 commits intosaghul:masterfrom
Conversation
Contributor
Author
|
It's not expected that the tests would pass with just this change. The vendored c-ares also needs to be updated. |
Owner
|
The test should check for either, for backwards compatibility. |
…-ares 1.16 and 1.24
Contributor
Author
|
The latest commit should do that. |
saghul
approved these changes
Jan 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #193
With this change, all tests pass with c-ares 1.24 (but will fail with 1.18).