Skip to content

Make ode functionality tested, add const-correctness#41311

Merged
vbraun merged 2 commits intosagemath:developfrom
user202729:gsl-ode
Dec 29, 2025
Merged

Make ode functionality tested, add const-correctness#41311
vbraun merged 2 commits intosagemath:developfrom
user202729:gsl-ode

Conversation

@user202729
Copy link
Copy Markdown
Contributor

@user202729 user202729 commented Dec 19, 2025

apparently the old interface was silently broken because of noexcept automatically added, making the signature different, see #36507 .

I fix the doctest and make it actually tested to avoid breakage in the future.

Also I add const-correctness (if you lookup the gsl documentation, you'll see that the y parameter is const).

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@user202729 user202729 marked this pull request as ready for review December 19, 2025 14:01
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 19, 2025 •
edited
Loading

Documentation preview for this PR (built with commit bf6982f; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@user202729 user202729 mentioned this pull request Dec 19, 2025
Open
5 tasks
@user202729
Copy link
Copy Markdown
Contributor Author

user202729 commented Dec 25, 2025

I notice the slow doctest warning here. But I don't think it's possible to have a faster test that tests this code path, and we certainly don't want cython compilation to suddenly break on meson.

@orlitzky any idea?

@orlitzky
Copy link
Copy Markdown
Contributor

orlitzky commented Dec 25, 2025

Add # long time? The compilation can probably be sped up, but if the point of the example is to improve the speed of the code, then we probably don't want to e.g. hack -O0 into the command.

@user202729
Copy link
Copy Markdown
Contributor Author

user202729 commented Dec 25, 2025

Then it won't be tested on meson? (#40158)

@orlitzky
Copy link
Copy Markdown
Contributor

orlitzky commented Dec 25, 2025

Oh. 🤷

I tried overriding my usual CFLAGS with -O0 and that doesn't even help. Most of the time is spent in cythonize. I don't think there's a way to speed that up.

@vbraun vbraun merged commit 5ace339 into sagemath:develop Dec 29, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cxzhong cxzhong cxzhong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@user202729 @orlitzky @cxzhong @vbraun