Skip to content

remove some deprecations in groups#39466

Merged
vbraun merged 5 commits intosagemath:developfrom
fchapoton:deprec_groups
Feb 21, 2025
Merged

remove some deprecations in groups#39466
vbraun merged 5 commits intosagemath:developfrom
fchapoton:deprec_groups

Conversation

@fchapoton
Copy link
Copy Markdown
Contributor

@fchapoton fchapoton commented Feb 6, 2025

found using the scripts in #39262

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

Copy link
Copy Markdown
Collaborator

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vbraun
Copy link
Copy Markdown
Member

vbraun commented Feb 9, 2025

Docbuild fails as in the CI run

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 11, 2025

Documentation preview for this PR (built with commit bc23f92; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@dcoudert
Copy link
Copy Markdown
Collaborator

it seems you must also remove homset.py from some meson.build files https://github.com/sagemath/sage/actions/runs/13259123232/job/37011513831?pr=39466#step:8:90

@fchapoton
Copy link
Copy Markdown
Contributor Author

oui, effectivement. Je deteste ce truc meson.. merci !

@fchapoton
Copy link
Copy Markdown
Contributor Author

@dcoudert : good to go ?

Copy link
Copy Markdown
Collaborator

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vbraun vbraun merged commit 556d5f0 into sagemath:develop Feb 21, 2025
@fchapoton fchapoton deleted the deprec_groups branch February 22, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants