Move bitness handling in doctest to the output checker#39207
Closed
tobiasdiez wants to merge 6 commits intosagemath:developfrom
Closed
Move bitness handling in doctest to the output checker#39207tobiasdiez wants to merge 6 commits intosagemath:developfrom
tobiasdiez wants to merge 6 commits intosagemath:developfrom
Conversation
Currently, the bit marker `# 32/64-bit` is handled after parsing the doctests by modifying the doctest source. This handling is now moved to the output checker, which checks that the result of a doctest coincides with the expected value. This change is made for compatibility with pytest, which itself handles the creation of doctests and thus doesn't invoke the `sources` handler (but allows to change the output checker).
|
Documentation preview for this PR (built with commit 12961cb; changes) is ready! 🎉 |
5 tasks
Contributor
Author
|
Surpassed by #40238. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the bit marker
# 32/64-bitis handled after parsing the doctests by modifying the doctest source. This handling is now moved to the output checker, which checks that the result of a doctest coincides with the expected value.This change is made for compatibility with pytest, which itself handles the creation of doctests and thus doesn't invoke the
sourceshandler (but allows to change the output checker).📝 Checklist
⌛ Dependencies